Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update iavl #7750

Merged
merged 2 commits into from
Mar 15, 2024
Merged

chore: update iavl #7750

merged 2 commits into from
Mar 15, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Mar 15, 2024 •
edited by coderabbitai bot
Loading

Closes: #XXX

What is the purpose of the change

Updates IAVL, will make a release after backporting. Should only be backported to IAVL v23.x branch.

This specifically fixes some pruning bugs.

When backporting, the v0.47.5-v23-osmo-6-iavl-v1 tag should be used instead of the commit hash that is used here.

Testing and Verifying

Tested against live mainnet.

Summary by CodeRabbit

  • Chores
    • Updated to version v23.0.7-iavl-v1 focusing on enhanced pruning capabilities.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v23.x backport patches to v23.x branch labels Mar 15, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2024 •
edited
Loading

Walkthrough

In version v23.0.7-iavl-v1, the update introduces an improvement to the IAVL (Immutable AVL Tree) mechanism within the Osmosis blockchain framework. This enhancement specifically targets the pruning process, making it more efficient. The adjustment is encapsulated in a single pull request, indicating a focused effort to refine data storage and retrieval operations on the platform.

Changes

File Path Change Summary
.../store/iavl/store.go Enhanced pruning functionality
.../store/iavl/versioned_tree.go Adjustments to tree management for better pruning efficiency
docs/.../changelog.md Documented the IAVL bump and its impact on pruning

🐇✨
In the realm of code, where data trees grow,
A rabbit hopped in, with changes in tow.
"Let's prune with care, and efficiency find,
For a blockchain that's swift, leaving lag behind."
With a hop and a skip, the update was shared,
In version v23, with nothing spared. 🌿🚀
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions GitHub Actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

coderabbitai[bot]
coderabbitai bot reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ea86019 and d9c9e6b.
Files ignored due to path filters (6)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
  • osmomath/go.mod is excluded by: !**/*.mod
  • osmoutils/go.mod is excluded by: !**/*.mod
  • x/epochs/go.mod is excluded by: !**/*.mod
  • x/ibc-hooks/go.mod is excluded by: !**/*.mod
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 1
CHANGELOG.md (1)
  • 70-73: The changelog entry for version v23.0.7-iavl-v1 correctly documents the IAVL bump to improve pruning as per the PR objectives and AI-generated summary. This update aligns with the described intention to enhance pruning capabilities within the Osmosis project.

@czarcas7ic czarcas7ic merged commit 0b70cb8 into main Mar 15, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/update-iavl branch March 15, 2024 15:37
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@czarcas7ic @mergify
chore: update iavl (#7750)
3c8448f 
* update iavl

* changelog

(cherry picked from commit 0b70cb8)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmoutils/go.mod
#	x/epochs/go.mod
#	x/ibc-hooks/go.mod
@mergify mergify bot mentioned this pull request Mar 15, 2024
Closed
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@czarcas7ic @mergify
chore: update iavl (#7750)
19aa053 
* update iavl

* changelog

(cherry picked from commit 0b70cb8)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmoutils/go.mod
#	x/epochs/go.mod
#	x/ibc-hooks/go.mod
@mergify mergify bot mentioned this pull request Mar 15, 2024
Merged
czarcas7ic added a commit that referenced this pull request Mar 15, 2024
@mergify @czarcas7ic
chore: update iavl (backport #7750) (#7755)
70f6e3f 
* chore: update iavl (#7750)

* update iavl

* changelog

(cherry picked from commit 0b70cb8)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmoutils/go.mod
#	x/epochs/go.mod
#	x/ibc-hooks/go.mod

* update sdk tag

* tidy

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Apr 9, 2024
@czarcas7ic
Revert "chore: update iavl (#7750)"
1a87fed 
This reverts commit 0b70cb8.
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@PaddyMc PaddyMc PaddyMc approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v23.x backport patches to v23.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czarcas7ic @PaddyMc